Skip to content

Commit

Permalink
Feature/dotnet 8 (#28)
Browse files Browse the repository at this point in the history
* Update base docker image to .NET 8 release version

* Bump SonarScanner Asp.NET runtime version

* Bump SonarScan version
  • Loading branch information
highbyte authored Nov 14, 2023
1 parent 3e315ac commit 0d6f563
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 26 deletions.
14 changes: 7 additions & 7 deletions BUILD_RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

_TODO: This workflow should be improved_

- Clone the GitHub repository locally
- Create new Git branch (feature/name-of-feature)
- Clone the GitHub repository locally.
- Create new Git branch (feature/name-of-feature).
- Decide what the new full version number should be. If it's a pre-release, use -beta suffix in version number.
- Build and push docker image
- Authenticate to ghcr.io using [these instructions](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry)
- `docker build -t ghcr.io/highbyte/sonarscan-dotnet:v1.0.0 .` where v1.0.0 is the full version number.
- `docker push ghcr.io/highbyte/sonarscan-dotnet:v1.0.0` where v1.0.0 is the full version number.
- Update `action.yml` to point to the new docker tag version,
- Update `README.md` instructions to the new version,
- Update `action.yml` to point to the new docker tag version.
- Update `README.md` instructions to the new version.
- Push new branch from local repository to GitHub.
- Create [GitHub release](https://github.com/highbyte/sonarscan-dotnet/releases) with the full version number.
- If pre-rerelease (beta), check the Pre-release box.
- Check the box to release it to the GitHub Marketplace.
- Publish the release
- Verify the release from a workflow in another repo using the new version
- If the version is not a pre-release, create a GitHub PR to merge the new branch to master
- Publish the release.
- Verify the release from a workflow in another repo using the new version.
- If the version is not a pre-release, create a GitHub PR to merge the new branch to master.
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM mcr.microsoft.com/dotnet/sdk:7.0
FROM mcr.microsoft.com/dotnet/sdk:8.0.100

LABEL "com.github.actions.name"="sonarscan-dotnet"
LABEL "com.github.actions.description"="Sonarscanner for .NET 7 with pull request decoration support."
LABEL "com.github.actions.description"="Sonarscanner for .NET 8 with pull request decoration support."
LABEL "com.github.actions.icon"="check-square"
LABEL "com.github.actions.color"="blue"

Expand All @@ -12,8 +12,8 @@ LABEL "homepage"="https://github.com/highbyte"
LABEL "maintainer"="Highbyte"

# Version numbers of used software
ENV SONAR_SCANNER_DOTNET_TOOL_VERSION=5.13.1 \
DOTNETCORE_RUNTIME_VERSION=5.0 \
ENV SONAR_SCANNER_DOTNET_TOOL_VERSION=5.14 \
DOTNETCORE_RUNTIME_VERSION=6.0 \
NODE_VERSION=20 \
JRE_VERSION=17

Expand Down
27 changes: 14 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

SonarScanner for .NET for use in Github Actions, with automatic pull request detection, analysis and decoration.

The current version supports .NET 7
The current version supports .NET 8
- For .NET 7, use version [2.2.6](https://github.com/marketplace/actions/sonarscan-dotnet?version=v2.2.6)
- For .NET 6, use version [2.1.5](https://github.com/marketplace/actions/sonarscan-dotnet?version=v2.1.5)
- For .NET 5, use version [2.0](https://github.com/marketplace/actions/sonarscan-dotnet?version=2.0)
- For .NET Core 3.1, use version [1.0.2](https://github.com/marketplace/actions/sonarscan-dotnet?version=1.0.2)
Expand All @@ -15,8 +16,8 @@ The current version supports .NET 7
## Simple use with SonarCloud

``` yaml
- name: SonarScanner for .NET 7 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.2.6
- name: SonarScanner for .NET 8 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.3.0
with:
# The key of the SonarQube project
sonarProjectKey: your_projectkey
Expand All @@ -34,8 +35,8 @@ The current version supports .NET 7
Also includes test results.
``` yaml
- name: SonarScanner for .NET 7 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.2.6
- name: SonarScanner for .NET 8 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.3.0
with:
# The key of the SonarQube project
sonarProjectKey: your_projectkey
Expand All @@ -57,8 +58,8 @@ Also includes test results.
Also includes test results.
``` yaml
- name: SonarScanner for .NET 7 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.2.6
- name: SonarScanner for .NET 8 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.3.0
with:
# The key of the SonarQube project
sonarProjectKey: your_projectkey
Expand All @@ -81,8 +82,8 @@ Also includes test results.
## Skip tests
``` yaml
- name: SonarScanner for .NET 7 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.2.6
- name: SonarScanner for .NET 8 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.3.0
with:
# The key of the SonarQube project
sonarProjectKey: your_projectkey
Expand All @@ -101,8 +102,8 @@ Also includes test results.
## Use pre-build command to add a custom NuGet repository
``` yaml
- name: SonarScanner for .NET 7 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.2.6
- name: SonarScanner for .NET 8 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.3.0
with:
# The key of the SonarQube project
sonarProjectKey: your_projectkey
Expand All @@ -123,8 +124,8 @@ Also includes test results.
## Use with self-hosted SonarQube
``` yaml
- name: SonarScanner for .NET 7 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.2.6
- name: SonarScanner for .NET 8 with pull request decoration support
uses: highbyte/sonarscan-dotnet@v2.3.0
with:
# The key of the SonarQube project
sonarProjectKey: your_projectkey
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: "sonarscan-dotnet"
description: "SonarScanner for .NET 7 with pull request decoration support."
description: "SonarScanner for .NET 8 with pull request decoration support."
author: "Highbyte"

inputs:
Expand Down Expand Up @@ -34,7 +34,7 @@ inputs:

runs:
using: "docker"
image: "docker://ghcr.io/highbyte/sonarscan-dotnet:v2.2.6"
image: "docker://ghcr.io/highbyte/sonarscan-dotnet:v2.3.0"

branding:
icon: 'check-square'
Expand Down

0 comments on commit 0d6f563

Please sign in to comment.