Misc refactoring and bug fixes. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Renderer, InputHandler, and AudioHandler as is used for emulation.
…r to reduce unnecessary complexity. Make SystemRunner more obvious to use. Remove SystemRunnerBuilder.
… AudioHandlers (and their associated context objects) to be more consistent.
…4.1. This fixes WASM host rendering to work in debug mode again.
…illity to stop playing sound when Cleanup is called, not the SystemRunner).
Add unit tests.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
This pull request encompasses a comprehensive refactoring and enhancement of system component interfaces and implementations, focusing on simplification, standardization of lifecycle management, and improved system component integration within a .NET project for Commodore 64 and generic computer system emulation.
PR Summary
The pull request introduces significant refactoring across system runners, input, audio, and renderer components to streamline initialization, cleanup, and system component interactions. Key changes include the removal of generic interfaces in favor of more unified and simplified designs, and the introduction of new lifecycle management methods across various system components.
SystemRunnerclass now includes enhanced constructors and lifecycle management methods (Init,ProcessInputBeforeFrame,Cleanup), aligning system components more closely.C64SkiaRenderer2band similar classes to implement a genericIRendererinterface, simplifying dependency on system and context types.SystemRunnerBuilderand its tests, indicating a shift towards direct instantiation and configuration ofSystemRunner.InitandCleanupmethods in context interfaces (IAudioHandlerContext,IInputHandlerContext,IRenderContext), standardizing component lifecycle management.