Skip to content

SadConsole improvements and updated documentation #447

SadConsole improvements and updated documentation

SadConsole improvements and updated documentation #447

Triggered via pull request September 1, 2024 12:26
Status Success
Total duration 10m 55s
Artifacts

codeql-analysis.yml

on: pull_request
Matrix: Analyze
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Analyze (csharp): src/libraries/Highbyte.DotNet6502.Systems.Commodore64/Video/Vic2SpriteManager.cs#L128
Potential stack overflow. Move the stackalloc out of the loop. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2014)
Analyze (csharp): src/libraries/Highbyte.DotNet6502.Systems.Commodore64/Video/Vic2SpriteManager.cs#L180
Potential stack overflow. Move the stackalloc out of the loop. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2014)
Analyze (csharp): src/libraries/Highbyte.DotNet6502.Systems.Commodore64/Video/Vic2SpriteManager.cs#L248
Potential stack overflow. Move the stackalloc out of the loop. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2014)
Analyze (csharp): src/libraries/Highbyte.DotNet6502.Systems.Commodore64/Video/Vic2SpriteManager.cs#L186
Potential stack overflow. Move the stackalloc out of the loop. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2014)
Analyze (csharp): src/libraries/Highbyte.DotNet6502.Systems.Commodore64/Video/Vic2SpriteManager.cs#L132
Potential stack overflow. Move the stackalloc out of the loop. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2014)
Analyze (csharp): src/libraries/Highbyte.DotNet6502.Impl.SilkNet/Commodore64/Input/C64SilkNetInputHandler.cs#L27
Non-nullable field '_c64SilkNetKeyboard' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Analyze (csharp): src/apps/Highbyte.DotNet6502.App.SadConsole/ConfigUI/C64MenuConsole.cs#L69
Nullability of reference types in type of parameter 'sender' of 'void C64MenuConsole.C64ConfigButton_Click(object sender, EventArgs e)' doesn't match the target delegate 'EventHandler' (possibly because of nullability attributes).
Analyze (csharp): src/apps/Highbyte.DotNet6502.App.SadConsole/ConfigUI/C64MenuConsole.cs#L76
The local function 'CreateLabel' is declared but never used
Analyze (csharp): src/apps/Highbyte.DotNet6502.App.SadConsole/ConfigUI/C64ConfigUIConsole.cs#L173
The local function 'CreateLabelValue' is declared but never used