Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.7 and Prawn 2.3 #51

Merged
merged 4 commits into from
Dec 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 10 additions & 21 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,34 +1,27 @@
name: Test

on: [push, pull_request]
on:
push:
branches:
- main
- 'dev**'
pull_request:

jobs:
test:
name: Test on ruby ${{ matrix.ruby_version }} and prawn ${{ matrix.prawn_version }}
name: Test on ruby ${{ matrix.ruby_version }}

runs-on: ubuntu-latest
# Run this build only on either pull request or push.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository

strategy:
matrix:
ruby_version:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
prawn_version:
- '2.3'
- '2.4'
exclude:
- ruby_version: '3.0'
prawn_version: '2.3'
- ruby_version: '3.1'
prawn_version: '2.3'
- ruby_version: '3.2'
prawn_version: '2.3'

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: hidakatsuya/action-setup-diff-pdf@v1
with:
Expand All @@ -38,11 +31,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}

- name: Install dependencies
run: |
gem install bundler
bundle install --gemfile gemfiles/prawn-${{ matrix.prawn_version }}.gemfile --jobs 4 --retry 3
bundler-cache: true

- name: Run Tests
run: xvfb-run -a bundle exec rake test
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

* Drop Ruby 2.6 support
* Drop Ruby 2.6 and 2.7 support
* Drop Prawn 2.3 support

## 5.3.0

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ See [test/pdf/prawn_integration/expect.pdf](https://github.com/hidakatsuya/prawn

### Prawn

2.3, 2.4
2.4

### Ruby

2.7, 3.0, 3.1, 3.2
3.0, 3.1, 3.2

## Installation

Expand Down
5 changes: 0 additions & 5 deletions gemfiles/prawn-2.3.gemfile

This file was deleted.

5 changes: 0 additions & 5 deletions gemfiles/prawn-2.4.gemfile

This file was deleted.

4 changes: 2 additions & 2 deletions prawn-emoji.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ Gem::Specification.new do |spec|
spec.homepage = 'https://github.com/hidakatsuya/prawn-emoji'
spec.license = 'MIT'

spec.required_ruby_version = '>= 2.7'
spec.required_ruby_version = '>= 3.0'

spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do
`git ls-files -z`.split("\x0").reject { |f| f.match(%r{^test/}) }
end
spec.require_path = 'lib'

spec.add_runtime_dependency 'prawn', '~> 2.3'
spec.add_runtime_dependency 'prawn', '~> 2.4'
spec.add_runtime_dependency 'unicode-emoji', '~> 3.1'
# Workaround for gem loading error in ruby 3.1
# https://github.com/prawnpdf/prawn/issues/1235
Expand Down