HHH-18901 possible fix for Duplicate annotation for class: interface org.hibernate.bytecode.enhance.spi.EnhancementInfo: @org.hibernate.bytecode.enhance.spi.EnhancementInfo(version="6.6.3.Final")" During WildFly TCK testing #9415
+56
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l typePool.clear from EnhancerImpl Signed-off-by: Scott Marlow <[email protected]>
…isses Signed-off-by: Scott Marlow <[email protected]>
|
After some discussion with Sanne in https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/HHH-18901.20Duplicate.20annotation.20for.20EnhancementInfo.20class/near/488724657, I'm converting this pr to be a draft so that it isn't merged as is. How does the ModelTypePool.resolutions cache impact the super (TypePool.Default) class enough to cause duplicate EnhancementInfo annotations to be added to the instrumented class? |
Signed-off-by: Scott Marlow <[email protected]>
…nhance.spi. to Core Pool Signed-off-by: Scott Marlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18901
Add clear method to ModelTypePool which seems to avoid the duplicate annotation problem.
Also add TRACE logging to show cache hit/miss in OverridingClassFileLocator to possibly help explore if this pull request negatively impacts the improvements made for resolving https://hibernate.atlassian.net/browse/HHH-18011 (Parallel entity enhancement causes a classloader cache stampede).