Dividend, All Sector Gainers and Loosers #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gogulnathv Please add some description about this PR. |
asrafalih
requested changes
Mar 3, 2022
| @@ -4,18 +4,22 @@ import { IndexEquityInfo } from './interface' | |||
| const nseIndia = new NseIndia() | |||
|
|
|||
| export const getGainersAndLosersByIndex = async (indexSymbol: string) => { | |||
There was a problem hiding this comment.
Make this 'indexSymbol' param as optional. So that user need not pass 'all' as index symbol. If 'indexSymbol' is undefined consider it as 'all'
src/index.ts
Outdated
| @@ -105,6 +106,9 @@ export class NseIndia { | |||
| getEquityCorporateInfo(symbol: string): Promise<EquityCorporateInfo> { | |||
| return this.getDataByEndpoint(`/api/quote-equity?symbol=${encodeURIComponent(symbol)}§ion=corp_info`) | |||
| } | |||
| getEquityCorporateActionsDividend(symbol: string): Promise<EquityCorporateInfo> { | |||
There was a problem hiding this comment.
Change the method name as 'getEquityDividend'
asrafalih
reviewed
Mar 9, 2022
| }) | ||
| return { | ||
| gainers: gainers.sort((a, b) => b.pChange - a.pChange), | ||
| loosers: losers.sort((a, b) => a.pChange - b.pChange) |
There was a problem hiding this comment.
Why 'loosers' instead of 'losers'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dividend, All Sector Gainers and Loosers