Add support for multiple Aldi (North) domains #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReneNulschDE
changed the title
jayaddison
reviewed
Nov 1, 2024
jayaddison
reviewed
Nov 1, 2024
|
Generally looks great to me, thank you @ReneNulschDE! Let me know what you think of those two suggestions, and any questions about them. One other small note - not directly relevant to this PR, but there seems to be some indication that the site might sometime include nutritional information with recipes. The relevant |
Co-authored-by: James Addison <[email protected]>
I have checked multiple pages and it was always empty. |
jayaddison
approved these changes
Nov 1, 2024
hhursev
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds scraper support for the different sites of the "ALDI Nord"-group. Aldi should be a well known supermarket in some countries on this planet. Schema based with modifications of the instructions.
Sites:
This my first PR to this project. So please give open and direct feedback. Further portals like ALDI Sued and some other are on my list to improve the experience in downstream projects that I use. Thanks to James for the help with my multi-domain problem.