Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(maangchi): use regex string to find ingredients header #1311

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

oahnh
Copy link
Contributor

@oahnh oahnh commented Oct 21, 2024

Resolves #1310

Utilizes a regex string to find ingredient headers matching patterns like "Ingredients (serves n to m)"

Example recipes

Unittests passing:
image

Any feedback or discussion is appreciated!

@jknndy
Copy link
Collaborator

jknndy commented Oct 21, 2024

This seems reasonable to me!

If you add Resolves #1310 to the body of the PR it will automatically when this is merged.

@oahnh oahnh requested a review from jayaddison October 22, 2024 01:36
@oahnh
Copy link
Contributor Author

oahnh commented Oct 22, 2024

I realized both of the commits got squashed into the formatting commit 🤦🏽 I updated per your suggestion in the chore: formatting commit

Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too - thank you for contributing, @oahnh!

@jayaddison jayaddison merged commit 4f86ebe into hhursev:main Oct 22, 2024
1 check passed
@oahnh oahnh deleted the maangchi-ingredients branch October 23, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Maangchi) Ingredients not being correctly scraped
3 participants