Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: non-schema retrieval for ratings and backup method for author #1307

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

jknndy
Copy link
Collaborator

@jknndy jknndy commented Oct 19, 2024

Resolves #1293

Ratings

  • ratings is now gathered by using the image titles shown in the comments section to display the ratings.

Author

  • added a backup retrieval method for author for instances where schema isn't available. see new test case.

@jknndy jknndy marked this pull request as ready for review October 19, 2024 17:53
Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Feel free to merge when ready, and then I'll rebase #1319 so that they involve one commit each.

@jknndy jknndy merged commit a4ed871 into hhursev:main Oct 22, 2024
19 checks passed
@jknndy jknndy deleted the usapear-improvments branch October 22, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usapears: ratings no-longer-available in schema.org metadata
2 participants