Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dequantify duplicate cols #207

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

MichaelTiemannOSC
Copy link
Collaborator

@MichaelTiemannOSC MichaelTiemannOSC commented Oct 20, 2023

Use enumeration to wade through duplicate column names. This does not preserve default column names when dequantifying, but it doesn't break. Should pint.dequantify() also preserve duplicated column names?

Use enumeration to wade through duplicate column names.  This does not preserve default column names when dequantifying, but it doesn't break.  Should `pint.dequantify()` also preserve duplicated column names?

Signed-off-by: Michael Tiemann <[email protected]>
Signed-off-by: Michael Tiemann <[email protected]>
@andrewgsavage
Copy link
Collaborator

andrewgsavage commented Oct 20, 2023

Should pint.dequantify() also preserve duplicated column names?

ideally yes

@andrewgsavage
Copy link
Collaborator

should add a test for it too

@andrewgsavage
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 34c4b03 into hgrecco:master Oct 28, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pint.dequantify() fails for duplicate column names
2 participants