Normalize trailing commas in data directory #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waldyrious Many thanks for spotting! Nice!! Merged |
|
@b-g Thanks for the additional fixes to the PR! However, I noticed that a trailing comma was added here and here. What happened there? Also, I have additional small fixes like these to submit, but also I might be able to contribute a substantial amount of data, as I mentioned here. Would that be welcome? |
|
@waldyrious This would be welcome :) |
|
Please be aware of
and combines it with data of the emojibase-data package ... and generates the data/openmoji.XXX files |
|
That's great information, thanks! 🙂 I will read the contribution guidelines so I don't miss similar details for my next contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small cleanup change: remove trailing commas within quoted lists. This was only present in a small minority of the entries, which were normalized to match the other ones.