fix(exp): configure response headers before sending them #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
changed the title
Ensure the headers are configured before we set the status code and send the headers.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 71.31% 71.28% -0.03%
==========================================
Files 45 45
Lines 3859 3862 +3
==========================================
+ Hits 2752 2753 +1
- Misses 692 694 +2
Partials 415 415 ☔ View full report in Codecov by Sentry. |
jooola
pushed a commit
that referenced
this pull request
Jun 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.1](v2.10.0...v2.10.1) (2024-06-25) ### Bug Fixes * **exp:** configure response headers before sending them ([#473](#473)) ([07d4a35](07d4a35)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Sep 12, 2024
…0.2 (hetznercloud/fleeting-plugin-hetzner!83) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.9.0` -> `v2.10.2` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.10.2`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.2) [Compare Source](hetznercloud/hcloud-go@v2.10.1...v2.10.2) ##### Bug Fixes - **exp:** allow request path matching in the want function ([#​475](hetznercloud/hcloud-go#475)) ([267879b](hetznercloud/hcloud-go@267879b)) ### [`v2.10.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.1) [Compare Source](hetznercloud/hcloud-go@v2.10.0...v2.10.1) ##### Bug Fixes - **exp:** configure response headers before sending them ([#​473](hetznercloud/hcloud-go#473)) ([07d4a35](hetznercloud/hcloud-go@07d4a35)) ### [`v2.10.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.0) [Compare Source](hetznercloud/hcloud-go@v2.9.0...v2.10.0) ##### Features - **exp:** add envutils package ([#​466](hetznercloud/hcloud-go#466)) ([a7636bd](hetznercloud/hcloud-go@a7636bd)) - **exp:** add labelutils with selector ([#​465](hetznercloud/hcloud-go#465)) ([1a55a7e](hetznercloud/hcloud-go@1a55a7e)) - **exp:** add mock utils package ([#​460](hetznercloud/hcloud-go#460)) ([92f7c62](hetznercloud/hcloud-go@92f7c62)) - **exp:** rename `AppendNextActions` to `AppendNext` ([#​452](hetznercloud/hcloud-go#452)) ([9b6239a](hetznercloud/hcloud-go@9b6239a)) - filter out nil actions in action waiter ([#​464](hetznercloud/hcloud-go#464)) ([4fc9a40](hetznercloud/hcloud-go@4fc9a40)) ##### Bug Fixes - nil check against the embedded `http.Response` ([#​469](hetznercloud/hcloud-go#469)) ([46e489a](hetznercloud/hcloud-go@46e489a)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxOC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the headers are configured before we set the status code and send the headers.