feat(error): include http status code in api errors

hetznercloud · Sep 19, 2023 · 8de4cfa · 8de4cfa
1 parent 7ddb2ec
commit 8de4cfa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/hcloud/client.go b/hcloud/client.go
@@ -371,7 +371,10 @@ func errorFromResponse(resp *http.Response, body []byte) error {
 	if respBody.Error.Code == "" && respBody.Error.Message == "" {
 		return nil
 	}
-	return ErrorFromSchema(respBody.Error)
+
+	hcErr := ErrorFromSchema(respBody.Error)
+	hcErr.HTTPStatusCode = resp.StatusCode
+	return hcErr
 }
 
 // Response represents a response from the API. It embeds http.Response.

diff --git a/hcloud/client_test.go b/hcloud/client_test.go
@@ -85,6 +85,9 @@ func TestClientError(t *testing.T) {
 	if apiError.Message != "An error occurred" {
 		t.Errorf("unexpected error message: %q", apiError.Message)
 	}
+	if apiError.HTTPStatusCode != http.StatusUnprocessableEntity {
+		t.Errorf("unexpected http status code: %q", apiError.HTTPStatusCode)
+	}
 }
 
 func TestClientInvalidToken(t *testing.T) {

diff --git a/hcloud/error.go b/hcloud/error.go
@@ -94,6 +94,9 @@ type Error struct {
 	Code    ErrorCode
 	Message string
 	Details interface{}
+	// HTTPStatusCode is the status code of the response that included the error.
+	// It can be converted to a user readable string using net/http.StatusText().
+	HTTPStatusCode int
 }
 
 func (e Error) Error() string {