Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Buildpack Output module #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- `libherokubuildpack`:
- Removed `buildpack_output` module. This functionality from ([#721](https://github.com/heroku/libcnb.rs/pull/721)) was experimental. The API was not stable and it is being removed. A similar API is available at [bullet_stream](https://crates.io/crates/bullet_stream). ([#852](https://github.com/heroku/libcnb.rs/pull/852)

## [0.22.0] - 2024-06-18

Expand Down
5 changes: 1 addition & 4 deletions libherokubuildpack/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ all-features = true
workspace = true

[features]
default = ["command", "download", "digest", "error", "log", "tar", "toml", "fs", "write", "buildpack_output"]
default = ["command", "download", "digest", "error", "log", "tar", "toml", "fs", "write"]
download = ["dep:ureq", "dep:thiserror"]
digest = ["dep:sha2"]
error = ["log", "dep:libcnb"]
Expand All @@ -27,7 +27,6 @@ tar = ["dep:tar", "dep:flate2"]
toml = ["dep:toml"]
fs = ["dep:pathdiff"]
command = ["write", "dep:crossbeam-utils"]
buildpack_output = []
write = []

[dependencies]
Expand All @@ -48,6 +47,4 @@ toml = { workspace = true, optional = true }
ureq = { version = "2.9.7", default-features = false, features = ["tls"], optional = true }

[dev-dependencies]
indoc = "2.0.5"
libcnb-test = { workspace = true }
tempfile = "3.10.1"
6 changes: 2 additions & 4 deletions libherokubuildpack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ Common utilities for buildpacks written with [libcnb.rs](https://github.com/hero
only used for official Heroku buildpacks. It was moved into the libcnb.rs repository as an incubator for utilities that
might find their way into libcnb.rs proper.

This crate is optional and not required to write buildpacks with libcnb.rs. It provides helpers that buildpack authors
commonly need. Examples are digest generation, filesystem utilities, HTTP download helpers and tarball extraction.
This crate is optional and not required to write buildpacks with libcnb.rs. It provides helpers that buildpack authors
commonly need. Examples are digest generation, filesystem utilities, HTTP download helpers and tarball extraction.

## Crate Features

Expand All @@ -24,8 +24,6 @@ The feature names line up with the modules in this crate. All features are enabl
Enables helpers to achieve consistent error logging.
* `log` -
Enables helpers for logging.
* `buildpack_output` -
Enables helpers for user-facing buildpack output.
* `tar` -
Enables helpers for working with tarballs.
* `toml` -
Expand Down
115 changes: 0 additions & 115 deletions libherokubuildpack/src/buildpack_output/ansi_escape.rs

This file was deleted.

66 changes: 0 additions & 66 deletions libherokubuildpack/src/buildpack_output/duration_format.rs

This file was deleted.

Loading