You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
libcnb-test has some tests that make use of the Procfile CNB for testing the start_container() API.
These tests intentionally don't pin to a specific version of the Procfile CNB, so that (a) we don't have to manually update it all the time, (b) we test against what's actually in the builder image and so what people will be using. This is generally fine, since normally there won't be breaking changes in the Procfile CNB that affect our tests.
However, Procfile v3.0.0 was just released with an intentional breaking change to the way that the command vs args are handled.
Specifically, before the Procfile file entry would be set as the process command but now it's set as args.
---- starting_containers stdout ----
thread 'starting_containers' panicked at libcnb-test/tests/integration_test.rs:502:21:
assertion failed: `(is empty)`
value (unescaped):
$DESIGNATION: line 1: Hello: command not found
value (escaped): `"$DESIGNATION: line 1: Hello: command not found\n"`
…801)
Procfile CNB v3.0.0 was just released with an intentional change to the
way that `command` vs `args` are handled in the CNB process type
definition. (Before the `Procfile` file entry would be set as the
process `command`, but now it's set as `args`.)
That change improves the overall UX of running images that use the
Procfile CNB, but is breaking in some lesser used scenarios that
happened to be tested via the `starting_containers` test in this repo.
See:
- heroku/buildpacks-procfile#205 (comment)
- heroku/buildpacks-procfile@v2.0.2...v3.0.0#diff-782521a81713992d3a07e85975d367cfac60afc78583133551efcddc2026bd3eL19-R20
The tests have been updated to account for the new behaviour, and an
additional test added for the "overriding command only" scenario (that
wasn't possible to easily test before due to the way the Procfile CNB
was previously implemented).
Fixes#800.
GUS-W-15139634.
libcnb-test
has some tests that make use of the Procfile CNB for testing thestart_container()
API.These tests intentionally don't pin to a specific version of the Procfile CNB, so that (a) we don't have to manually update it all the time, (b) we test against what's actually in the builder image and so what people will be using. This is generally fine, since normally there won't be breaking changes in the Procfile CNB that affect our tests.
However, Procfile v3.0.0 was just released with an intentional breaking change to the way that the command vs args are handled.
Specifically, before the
Procfile
file entry would be set as the processcommand
but now it's set asargs
.See:
As a result, CI for this repo is failing with:
eg:
https://github.com/heroku/libcnb.rs/actions/runs/8079052018/job/22073194983#step:8:256
We'll need to update the test here accordingly:
libcnb.rs/libcnb-test/tests/integration_test.rs
Lines 445 to 513 in 5c78f1d
The text was updated successfully, but these errors were encountered: