-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
starting_containers
test after release of Procfile CNB v3.0.0 (#…
…801) Procfile CNB v3.0.0 was just released with an intentional change to the way that `command` vs `args` are handled in the CNB process type definition. (Before the `Procfile` file entry would be set as the process `command`, but now it's set as `args`.) That change improves the overall UX of running images that use the Procfile CNB, but is breaking in some lesser used scenarios that happened to be tested via the `starting_containers` test in this repo. See: - heroku/buildpacks-procfile#205 (comment) - heroku/buildpacks-procfile@v2.0.2...v3.0.0#diff-782521a81713992d3a07e85975d367cfac60afc78583133551efcddc2026bd3eL19-R20 The tests have been updated to account for the new behaviour, and an additional test added for the "overriding command only" scenario (that wasn't possible to easily test before due to the way the Procfile CNB was previously implemented). Fixes #800. GUS-W-15139634.
- Loading branch information
Showing
2 changed files
with
19 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
web: python3 -u -m http.server ${PORT:+"${PORT}"} | ||
worker: echo 'this is the worker process!' | ||
echo-args: echo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters