Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rune Soerensen <[email protected]>
  • Loading branch information
schneems and runesoerensen authored Oct 2, 2024
1 parent 32baa5f commit ebac8c0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions libherokubuildpack/src/inventory.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
//! # Inventory
//!
//! Many buildpacks need to provided artifacts from different URLs. A helpful pattern
//! Many buildpacks need to provide artifacts from different URLs. A helpful pattern
//! is to provide a list of artifacts in a TOML file, which can be parsed and used by
//! the buildpack to download the correct artifact. For example, a Ruby buildpack
//! might need to download pre-compiled Ruby binary versions that are hosted on S3.
//! might need to download pre-compiled Ruby binaries hosted on S3.
//!
//! This module contains code that can be used to produce and consume such an inventory file.
//! This module can be used to produce and consume such an inventory file.
//!
//! ## Features
//!
Expand Down Expand Up @@ -117,9 +117,6 @@ impl<V, D, M> Inventory<V, D, M> {
}

/// Add a new artifact to the in-memory inventory
///
/// For removal, you can use the `Vec::retain` method on the artifacts attribute
/// to remove artifacts that match a given predicate.
pub fn push(&mut self, artifact: Artifact<V, D, M>) {
self.artifacts.push(artifact);
}
Expand Down
2 changes: 1 addition & 1 deletion libherokubuildpack/src/inventory/artifact.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use std::str::FromStr;
/// An inventory is made up of multiple artifacts that have a version that
/// can be compared to each other and a URL where the artifact can be downloaded.
///
/// Some artifacts may be OS or architectures specific. The checksum value can
/// Artifacts are OS and architectures specific. The checksum value can
/// be used to validate an artifact once it has been downloaded.
///
/// Metadata can be used to store additional information about the artifact.
Expand Down

0 comments on commit ebac8c0

Please sign in to comment.