Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 and multi-arch support #225

Merged
merged 4 commits into from
May 2, 2024
Merged

arm64 and multi-arch support #225

merged 4 commits into from
May 2, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented May 2, 2024

There's really nothing to do here except add a changelog entry; the buildpack.toml already has both targets. The next release will be published as multi-arch, since heroku/languages-github-actions#194 is merged.

@joshwlewis joshwlewis marked this pull request as ready for review May 2, 2024 21:10
@joshwlewis joshwlewis requested a review from a team as a code owner May 2, 2024 21:10
CHANGELOG.md Show resolved Hide resolved
@joshwlewis joshwlewis changed the title arm64 and multiarch support arm64 and multi-arch support May 2, 2024
Co-authored-by: Ed Morley <[email protected]>
@joshwlewis joshwlewis merged commit a516aca into main May 2, 2024
4 checks passed
@joshwlewis joshwlewis deleted the multi-arch branch May 2, 2024 21:23
@edmorley
Copy link
Member

edmorley commented May 2, 2024

The release looks like it's single arch (only the one .cnb attached):
https://github.com/heroku/buildpacks-procfile/releases/tag/v3.1.0

The actions repo needs a release first:
https://github.com/heroku/languages-github-actions/actions/workflows/release.yml

@joshwlewis
Copy link
Member Author

The release looks like it's single arch

Damn. I guess I'll bump this to 3.1.1 and release it again, since I can't republish the same version to the CNB registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants