Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced custom memory addr type with memory_address #9

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

jounathaen
Copy link
Member

This removes the align_down_to_base_page etc. functions, as well as some operators (e.g., rem). But these can be easily replaced with, e.g., use align_address::Align; myaddr.align_down(BASE_PAGE_SIZEl);

-> requires a version bump

@jounathaen
Copy link
Member Author

To fix clippy, this is now also non-nightly at the cost of requiring Rust 1.82

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd want this crate to depend on memory-addresses but the other way around to make this crate self-governing regarding the guarantees and arch-specific methods on these types.

Let's talk about it. :)

@jounathaen jounathaen added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 12, 2024
@jounathaen jounathaen added this pull request to the merge queue Nov 12, 2024
@jounathaen jounathaen removed this pull request from the merge queue due to a manual request Nov 12, 2024
@jounathaen jounathaen merged commit 603046b into master Nov 12, 2024
3 checks passed
@jounathaen jounathaen deleted the memory_addr branch November 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants