specify the toolchain for which llvm-tools is to be installed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was the case when I was in the kernel repository and building rftrace through xtask, since hermit-rs and kernel currently don't use the same toolchain version. |
mkroening
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Ah, yes. I recently stumbled over the same issue (hermit-os/kernel@2239624).
If the user is in a project with a different toolchain than the one rftrace is being built with, the component install without the toolchain argument defaults to the wrong toolchain. This change makes the error message provide the possibly necessary argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is in a project with a different toolchain than the one rftrace is being built with, the component install without the toolchain argument defaults to the wrong toolchain. This change makes the error message provide the possibly necessary argument.