Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra reference #10

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove extra reference #10

merged 1 commit into from
Oct 10, 2024

Conversation

gabmontes
Copy link

What it solves

Build fails after #9.

How this PR fixes it

Just removes the extra reference to AppstoreButton.

@gabmontes gabmontes requested a review from gndelia October 10, 2024 21:49
@gabmontes gabmontes self-assigned this Oct 10, 2024
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 947.25 KB (🟢 -13.93 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 24.85 KB (🟢 -19 B) 972.1 KB
/404 697 B (🟢 -1 B) 947.93 KB
/_error 230 B (🟡 +2 B) 947.47 KB
/_offline 1.09 KB (🟢 -3 B) 948.34 KB
/addOwner 535 B (🟡 +1 B) 947.77 KB
/address-book 26.1 KB (🟡 +15 B) 973.35 KB
/apps 49.57 KB (🟡 +1.17 KB) 996.82 KB
/apps/bookmarked 446 B (🟡 +1 B) 947.69 KB
/apps/custom 41.19 KB (🟡 +1.16 KB) 988.44 KB
/apps/open 50.89 KB (🟢 -2.22 KB) 998.14 KB
/balances 29.42 KB (🟢 -1.51 KB) 976.67 KB
/balances/nfts 19.16 KB (🟢 -18 B) 966.41 KB
/cookie 8.76 KB (🟡 +27 B) 956.01 KB
/home 59.37 KB (🟡 +1.25 KB) 1006.62 KB
/imprint 1.38 KB (🟡 +13 B) 948.63 KB
/licenses 5 KB (🟡 +26 B) 952.25 KB
/new-safe/create 26.4 KB (🟢 -7.95 KB) 973.65 KB
/new-safe/load 16.24 KB (🟢 -165 B) 963.49 KB
/privacy 15.76 KB (🟢 -116 B) 963.01 KB
/settings 450 B (🟢 -1 B) 947.69 KB
/settings/appearance 8.44 KB (🟡 +412 B) 955.69 KB
/settings/cookies 7.64 KB (🟢 -24 B) 954.89 KB
/settings/data 7.54 KB (🟢 -21 B) 954.79 KB
/settings/environment-variables 9.13 KB (🟢 -23 B) 956.38 KB
/settings/modules 9.62 KB (🟢 -167 B) 956.87 KB
/settings/notifications 27.79 KB (🟡 +777 B) 975.04 KB
/settings/safe-apps 25.41 KB (🟡 +1.49 KB) 972.66 KB
/settings/security 8.45 KB (🟡 +368 B) 955.7 KB
/settings/setup 35.96 KB (🟢 -24 B) 983.21 KB
/share/safe-app 10.12 KB (🟡 +408 B) 957.37 KB
/swap 29.4 KB (🔴 +28.68 KB) 976.65 KB
/terms 10.03 KB (🔴 +9.5 KB) 957.28 KB
/transactions 73.92 KB (🟡 +402 B) 1021.17 KB
/transactions/history 73.89 KB (🟡 +401 B) 1021.14 KB
/transactions/messages 34.87 KB (🟢 -4.31 KB) 982.12 KB
/transactions/queue 29.16 KB (🟢 -2.12 KB) 976.41 KB
/transactions/tx 18.91 KB (🟢 -2.18 KB) 966.16 KB
/wc 689 B (🟡 +2 B) 947.92 KB
/welcome 6.77 KB (🟢 -33 B) 954.02 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@gabmontes gabmontes merged commit fe10dfe into hemi-main Oct 10, 2024
5 of 14 checks passed
@gabmontes gabmontes deleted the clean-footer branch October 10, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants