tbcd, bfgd: add various hemi specific indexes #380
Conversation
marcopeereboom
added
type: feature
marcopeereboom
requested review from
a team and
ClaytonNorthey92
as code owners
joshuasing
changed the title
| @@ -1215,20 +1214,387 @@ func (s *Server) TxIndexer(ctx context.Context, endHash *chainhash.Hash) error { | |||
| return fmt.Errorf("invalid direction: %v", direction) | |||
| } | |||
|
|
|||
| func processKeystones(blockHash *chainhash.Hash, txs []*btcutil.Tx, kssCache map[chainhash.Hash]tbcd.Keystone) error { | |||
There was a problem hiding this comment.
TODO before merge: add a test case for this
There was a problem hiding this comment.
I think we need to a add a test case here, to ensure that we pull the correct bytes off of a btcutil.Tx and store them correctly
…ng change to actual address to keep createPoPTx happy
marcopeereboom
force-pushed
the
marco/hemiindex
branch
from
a98c8f0 to
d5eed69
Compare
There was a problem hiding this comment.
hey @marcopeereboom I have a few changes to request; most requests are around test coverage, there is one indexing question that I have as well.
Co-authored-by: Joshua Sing <[email protected]>
Co-authored-by: Joshua Sing <[email protected]>
database/tbcd/level/level_test.go
Outdated
| if err == nil { | ||
| t.Fatalf("keystone in db: %v", spew.Sdump(v)) | ||
| } else { | ||
| _, ok := err.(database.NotFoundError) |
There was a problem hiding this comment.
it's probably better to use errors.Is here
database/tbcd/level/level_test.go
Outdated
| name: "invalidRemove", | ||
| direction: []int{-1}, | ||
| kssMap: invalidKssCache, | ||
| expectedOutDB: anyKssCache, |
There was a problem hiding this comment.
hey @AL-CT could we define these not as variables, but as each their own map[chainhash.Hash]tbcd.Keystone?
for example:
expectedOutDB: map[chainhash.Hash]tbcd.Keystone{
...
}I fear that sharing variables between tests here may cause unexpected behavior
There was a problem hiding this comment.
fair, also forced me to make things more readable when fixing it
Summary
Hemi needs to keep track of L2 keystones in order to provide callers the bitcoin view of the hemi network.
Changes
This PR adds L2 keystone indexing and hides this behind a configuration flag.