change paradigm from checking for missing childrent to keeping track of tip via electrs #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of tip via electrs prior, to solve for forks we would try to fill in "missing children". the way we (I) had written it, there is no way to guarantee that we will get to the tip; if there were siblings at that height then we would not check for missing blocks. a better way to do it it to check for the tip of the btc chain to change; when that changes, update the btc chain until we get to a known block
github-actions
bot
added
the
area: bfg
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom,
joshuasing and
AL-CT
|
this is failing a localnet test, I will dive deeper in the AM |
ClaytonNorthey92
removed request for
a team,
jcvernaleo,
max-sanchez,
marcopeereboom,
joshuasing and
AL-CT
github-actions
bot
added
the
area: ci
updating height cache
ClaytonNorthey92
force-pushed
the
clayton/tip-check
branch
from
201f64d to
72c05d2
Compare
|
ok localnet test passes https://github.com/hemilabs/heminetwork/actions/runs/12761873612/job/35569512517 |
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom,
joshuasing and
AL-CT
|
|
||
| log.Tracef("checking for missing blocks, walking from tip %d to %d or first known block from tip", height, s.cfg.BTCStartHeight) | ||
|
|
||
| for height > s.cfg.BTCStartHeight { |
ClaytonNorthey92
removed request for
jcvernaleo,
max-sanchez and
marcopeereboom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prior, to solve for forks we would try to fill in "missing children". the way we (I) had written it, there is no way to guarantee that we will get to the tip; if there were siblings at that height then we would not check for missing blocks.
a better way to do it it to check for the tip of the btc chain to change; when that changes, update the btc chain until we get to a known block
Changes
rather than walking up the btc chain, monitor the tip and walk down until we come across a known block
fixes #370