Fix: Allow proper cancellation of default browser actions on iOS #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello hello! Thanks for the PR! Apologies for not getting to this sooner. I might be misunderstanding the change here, I'm not seeing a change on iOS using the storybook link. When I drag on iOS 16.3.1 the page continues to scroll with the touch movement. Note that you can test dnd without the iframe using this link and scrolling appears to work as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deceptively small commit fixes an issue that most likely have been introduced by the Firefox fix (see line 122).
Current behavior:
On iOS, scroll (at least inside iframes) isn't getting cancelled because the
touchmoveis a passive listener. Callinge.preventDefault()in line 145 doesn't actually do anything.New behavior
Adding
passive: falsemakes the listener active, and everything works as intended (scroll is stopped when drag starts). Weirdly enough, the comment in line 120 already suggests this is being done, but...it wasn't 😅