Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana Ledger Integration (v2.3.0) #477

Merged
merged 16 commits into from
Oct 10, 2023
Merged

Solana Ledger Integration (v2.3.0) #477

merged 16 commits into from
Oct 10, 2023

Conversation

Perronef5
Copy link
Contributor

@Perronef5 Perronef5 commented Sep 22, 2023 •
edited
Loading

CHANGES 📲

  • Add Solana Ledger App Package
  • Allow Ledger Accounts to be imported into the app
  • Add Ledger signing to Anchor Provider
  • Add prompt to open Solana Ledger App if app is not open when signing txn
  • Add Ledger Illustrations for device actions

DEMO 📷

Account Setup

IMPORT LEDGER WALLET

IMG_1848

SCAN FOR LEDGER

IMG_1849

SELECT ACCOUNTS TO IMPORT

IMG_1850

ACCOUNTS IMPORTED

IMG_1851

RPReplay_Final1695618751.MP4

LEDGER MODAL

OPEN SOLANA APP

IMG_1845

CONFIRM TRANSACTION

IMG_1843

RPReplay_Final1695618714.MP4

TODO 📝

  • Test all transactions
  • Test App with no accounts
  • Test non ledger accounts
  • Update HPL to use anchor v0.28.0 so that it supports Versioned Transactions

@Perronef5 Perronef5 changed the title Feat/ledger solana Feat/ledger solana (v2.3.0) Sep 22, 2023
@Perronef5 Perronef5 changed the title Feat/ledger solana (v2.3.0) Solana Ledger Integration (v2.3.0) Sep 22, 2023
@Perronef5 Perronef5 self-assigned this Sep 22, 2023
@Perronef5 Perronef5 added this to the v2.3.0 milestone Sep 22, 2023
@Perronef5 Perronef5 marked this pull request as ready for review September 25, 2023 05:28
@Perronef5 Perronef5 requested a review from a team as a code owner September 25, 2023 05:28
@Perronef5 Perronef5 requested review from allenan, tyler-whitman and elsie-c and removed request for a team September 25, 2023 05:28
@Perronef5 Perronef5 merged commit c541ca2 into main Oct 10, 2023
2 checks passed
@Perronef5 Perronef5 deleted the feat/ledger-solana branch October 10, 2023 21:52
ChewingGlass added a commit that referenced this pull request Oct 11, 2023
@ChewingGlass
Revert "Solana Ledger Integration (v2.3.0) (#477)"
069bf7c 
This reverts commit c541ca2.
abhay pushed a commit that referenced this pull request Oct 11, 2023
@ChewingGlass
Revert "Solana Ledger Integration (v2.3.0) (#477)" (#504)
74caf62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryzettler bryzettler bryzettler approved these changes

@allenan allenan Awaiting requested review from allenan allenan is a code owner automatically assigned from helium/app-team

@tyler-whitman tyler-whitman Awaiting requested review from tyler-whitman tyler-whitman is a code owner automatically assigned from helium/app-team

@elsie-c elsie-c Awaiting requested review from elsie-c elsie-c is a code owner automatically assigned from helium/app-team

Assignees

@Perronef5 Perronef5

Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Perronef5 @bryzettler