spl-memo on delegate dc #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryzettler
requested review from
allenan,
tyler-whitman,
Perronef5,
abhay and
ChewingGlass
and removed request for
a team
abhay
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
wallet to purchase DC directly towards OUI 1 and have their console account balance updated.
How does it work
Under the hood, it's about checking
• does the delegation txn have a memo that's associated with an console user account?
• how much DC is delegated
so Foundation Console can look at the txn and say "ok console user xyz, your account balance has been increased by xyz amount"
Why a memo is needed
A memo needs to be associated with a console account, otherwise console account A can steal account B's delegate txn.
example tx https://explorer.solana.com/tx/3BXHy7NTuRkhdVzPV8YJvhaqAUWRuCXdZrvSTu8LhUjaAEy9zSaAc8y9Fw3nVJ8X7H2RY51zpn1mo1QFajNikoU7?cluster=devnet