[Mobile Config] Add device_types filter to stream_gateways_info #880
+288
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
changed the title
kurotych
force-pushed
the
gateway_info_stream_filtered
branch
from
a419d30
to
ef9d21a
Compare
mobile_config/src/gateway_service.rs
Outdated
| tracing::debug!("fetching all gateways' info"); | ||
| tracing::debug!( | ||
| "fetching all gateways' info. Device types: {:?} ", | ||
| request.device_types |
There was a problem hiding this comment.
should this debug statement come after the map below? it would debug to a vec of i32s before that conversion, no?
mobile_config/src/gateway_info.rs
Outdated
Comment on lines
76
to
85
| impl DeviceType { | ||
| fn to_sql_argument(&self) -> String { | ||
| match self { | ||
| DeviceType::Cbrs => "\"cbrs\"".to_string(), | ||
| DeviceType::WifiIndoor => "\"wifiIndoor\"".to_string(), | ||
| DeviceType::WifiOutdoor => "\"wifiOutdoor\"".to_string(), | ||
| DeviceType::WifiDataOnly => "\"wifiDataOnly\"".to_string(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
should be able to make this more general and just impl std::fmt::Display for this, avoid the escape characters, and it will work just as well
There was a problem hiding this comment.
I've made it more generic but still forced to use quotas to make it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.