Madninja/solana #321
Merged
Madninja/solana #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some infrastructure for txns
* hotspot data only add command * rm unused deps * Refactor client, do_hotspot add * Limit to iot and dataonly hotspots * use pubkey deserializer --------- Co-authored-by: Marc Nijdam <[email protected]> Co-authored-by: Chewing Glass <[email protected]>
madninja
force-pushed
the
madninja/solana
branch
from
6e724ac
to
60367ec
Compare
abhay
reviewed
Jul 31, 2023
bin/helium-wallet-old
Outdated
There was a problem hiding this comment.
What's this file that was added? old copy of the binary? I don't think we should check it in, if so.
There was a problem hiding this comment.
yeah, fixed in 39ab01f. If I squash this PR it'll go away..
|
Let's land this and figure out the bulk claim thing later. |
abhay
approved these changes
Aug 3, 2023
yup definitely want to help iterate on this and bulk claim is very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings basic functionality back to the wallet cli. Based on similar commands as the original CLI and revamped for Solana for hotspot and account related commands