Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIP-124] Implement rewards and tracking for positions that vote #713

Merged
merged 19 commits into from
Oct 23, 2024

Conversation

ChewingGlass
Copy link
Collaborator

No description provided.

@ChewingGlass ChewingGlass marked this pull request as draft October 11, 2024 19:56
@ChewingGlass ChewingGlass marked this pull request as ready for review October 21, 2024 21:01
@ChewingGlass ChewingGlass changed the title HIP-124 Implementation [HIP-124] Implement rewards and tracking for positions that vote Oct 21, 2024
Comment on lines +29 to +32
case "positionVotingRewardsProgram":
return new PublicKey("pvr1pJdeAcW6tzFyPRSmkL5Xwysi1Tq79f7KF2XB4zM");
case "positionVotingRewards":
return new PublicKey("pvr1pJdeAcW6tzFyPRSmkL5Xwysi1Tq79f7KF2XB4zM");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case they use with or without the program prefix, given there's no positionVotingRewards account

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I did this in one of the programs, just felt more natural)

@ChewingGlass
Copy link
Collaborator Author

/canary-release

@ChewingGlass ChewingGlass merged commit b283161 into develop Oct 23, 2024
42 of 45 checks passed
@ChewingGlass ChewingGlass deleted the feat/HIP-124 branch October 23, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants