Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ability to add organization in Nova console (and invite-only envs) #1223

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ambuznego
Copy link
Collaborator

No description provided.

@vicmgs
Copy link
Contributor

vicmgs commented Jul 11, 2022

we can probably surface the "vetted" attribute through some newly created endpoint that is called on organizationIndex page if USER_INVITE_ONLY?

or in checkRegisteredUser in auth/magic.js, dispatch something to store that says this user cannot create orgs

@ambuznego ambuznego changed the title Limit ability to add organization in Nova console Limit ability to add organization in Nova console (and invite-only envs) Jul 11, 2022
@ambuznego ambuznego marked this pull request as ready for review July 11, 2022 23:15
@ambuznego ambuznego requested a review from vicmgs July 11, 2022 23:15
case get_user_by_id(user_id) do
%{super: is_super} -> get_user_data_map(user_id, email, is_super)
_ -> get_user_data_map(user_id, email)
%{super: is_super} -> get_user_data_map(user_id, email, vetted, is_super)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we default superuser to vetted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added!

Copy link
Contributor

@vicmgs vicmgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants