meta: update packages #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| export const Markdown: FC<MarkdownProps> = ({ text, isNonSelectable }) => { | ||
| if (!text) return null | ||
|
|
||
| const innerHTML = { __html: md.render(text) } |
Check warning
Code scanning / CodeQL
Unsafe HTML constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we need to ensure that the text input is sanitized before it is used to construct HTML content. This can be achieved by using a library that sanitizes HTML, such as dompurify. This will help prevent XSS attacks by removing any potentially harmful scripts from the input.
- Install the
dompurifylibrary. - Import
dompurifyin theMarkdown.tsxfile. - Use
dompurifyto sanitize thetextinput before passing it tomd.render.
Suggested changeset
2
packages/components/components/Markdown/Markdown.tsx
| @@ -5,2 +5,3 @@ | ||
| import type { MarkdownProps } from "./Markdown.types" | ||
| import DOMPurify from 'dompurify'; | ||
|
|
||
| @@ -9,3 +10,4 @@ | ||
|
|
||
| const innerHTML = { __html: md.render(text) } | ||
| const sanitizedText = DOMPurify.sanitize(text); | ||
| const innerHTML = { __html: md.render(sanitizedText) } | ||
| const markdownClasses: string = getClasses(styles.markdown, { |
packages/components/package.json
Outside changed files
| @@ -39,3 +39,4 @@ | ||
| "react-dom": "^19.0.0", | ||
| "react-plock": "^3.4.0" | ||
| "react-plock": "^3.4.0", | ||
| "dompurify": "^3.2.3" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| dompurify (npm) | 3.2.3 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.