Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully reject HTTP 1.0 connections #9715

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Gracefully reject HTTP 1.0 connections #9715

merged 1 commit into from
Feb 4, 2025
+105 −14

Conversation

spericas
Copy link
Member

@spericas spericas commented Jan 29, 2025 •
edited
Loading

Description

  • Gracefully reject HTTP 1.0 connections with a 505 error code (and log entry) that are routed directly to our 1.1 provider
  • If multiple providers are available, we cannot easily return 505 but we now detect HTTP 1.0 and log an informative message

Documentation

None

@spericas spericas added enhancement New feature or request webserver 4.x Version 4.x labels Jan 29, 2025
@spericas spericas added this to the 4.x milestone Jan 29, 2025
@spericas spericas self-assigned this Jan 29, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 29, 2025
@spericas spericas marked this pull request as draft January 29, 2025 21:17
@spericas
Gracefully reject HTTP 1.0 connections that are either ignored by all…
8e210c4 
… our providers or directly routed to our 1.1 provider. We always route to 1.1 if only a single provider is found. Returns HTTP error code 505 (HTTP version not supported) instead of 400 as before.
@spericas spericas requested a review from tomas-langer January 30, 2025 15:04
@spericas spericas marked this pull request as ready for review January 30, 2025 15:04
barchetta
barchetta approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 6062259 into helidon-io:main Feb 4, 2025
58 checks passed
@spericas spericas mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

@tjquinno tjquinno Awaiting requested review from tjquinno

Assignees

@spericas spericas

Labels
4.x Version 4.x enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
Backlog
Status: Closed
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @barchetta