Skip to content

Commit

Permalink
coveralls
Browse files Browse the repository at this point in the history
  • Loading branch information
helgasoft committed May 16, 2024
1 parent 2ca110f commit e77ef50
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test-coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
CI_BRANCH: "main"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-r@v2
- uses: r-lib/actions/setup-r@v4
with:
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v2
- uses: r-lib/actions/setup-r-dependencies@v4
with:
extra-packages: covr

Expand Down
4 changes: 3 additions & 1 deletion R/echarty.R
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,9 @@ ec.init <- function( df= NULL, preset= TRUE, ctype= 'scatter', ...,
}

if ('leaflet' %in% load) {
stopifnot("ec.init: library 'leaflet' not installed"= file.exists(file.path(.libPaths(), 'leaflet')[[1]]))
# coveralls pops error, win/linux ok :
#stopifnot("ec.init: library 'leaflet' not installed"= file.exists(file.path(.libPaths(), 'leaflet')[[1]]))
if (!file.exists(file.path(.libPaths(), 'leaflet')[[1]])) warning("ec.init: library 'leaflet' not installed")
if (preset) {
# customizations for leaflet
wt$x$opts$xAxis <- wt$x$opts$yAxis <- NULL
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interactive charts in R and Shiny with minimal overhead.

Wider connectivity and deployment potential through [crosstalk](https://rpubs.com/echarty/crosstalk) and .

<details> <summary>**Compare to echarts4r 📌**</summary>
<details> <summary><b>Compare to echarts4r</b> 📌</summary>

R package | echarts4r | echarty
--- | --- | ---
Expand Down

0 comments on commit e77ef50

Please sign in to comment.