Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: patrimoine integration #746

Open
wants to merge 5 commits into
base: preprod
Choose a base branch
from
Open

feat: patrimoine integration #746

wants to merge 5 commits into from

Conversation

lianafinaritra
Copy link
Collaborator

No description provided.

@lianafinaritra lianafinaritra marked this pull request as draft December 5, 2024 08:15
@lianafinaritra lianafinaritra force-pushed the feat/patrimoine-integration branch from b309c40 to bd6f16f Compare December 6, 2024 11:05
Mahefaa
Mahefaa requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Mahefaa Mahefaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed, using a jar as a dependency is so much better but still ok

src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
@lianafinaritra lianafinaritra marked this pull request as ready for review December 18, 2024 10:58
Mahefaa
Mahefaa requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Mahefaa Mahefaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the "Devise' class only added here

src/main/java/school/hei/haapi/endpoint/rest/controller/FeeController.java Outdated Show resolved Hide resolved
@lianafinaritra lianafinaritra force-pushed the feat/patrimoine-integration branch from e2d4bdf to f57a60b Compare December 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahefaa Mahefaa Mahefaa requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lianafinaritra @Mahefaa