Map backend #12 - added a map to store default in backend #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsutton
reviewed
Feb 5, 2019
backend/backend.go
Outdated
| @@ -21,9 +21,15 @@ func Func(name string, fn func(context.Context, string) ([]byte, error)) Backend | |||
| return &backendFunc{fn: fn, name: name} | |||
| } | |||
|
|
|||
| // Func creates a Backend from a function and allows users to add a defai;t map. | |||
There was a problem hiding this comment.
ty for the catch, submitting something to fix it =)
|
@alsutton If this looks okay should we merge it? |
|
Sorry for the delay guys, this one will be reviewed as soon as possible. Thank you for your understanding. |
|
All good! Ty for the response |
rogpeppe
suggested changes
Sep 19, 2019
| @@ -21,9 +21,15 @@ func Func(name string, fn func(context.Context, string) ([]byte, error)) Backend | |||
| return &backendFunc{fn: fn, name: name} | |||
| } | |||
|
|
|||
| // FuncWithDefaults creates a Backend from a function and allows users to add a default map. | |||
| func FuncWithDefaults(name string, defaults map[string]string, fn func(context.Context, string) ([]byte, error)) Backend { | |||
There was a problem hiding this comment.
I don't understand what this is doing. The defaults value here is never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, we are adding a map of defaults for usage by the different backends. Based on the ticket, I believe this is what is required, however I do apologize if I misunderstood it
I also wasn't sure if a the type
map[string][string]is the best solution. I was thinking of using amap[string]interface{}, but wasn't sure if the user would want to define an object as a valueIssue # 12