Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Error handling #161

Merged
merged 24 commits into from
Dec 10, 2023
Merged

feat: Error handling #161

merged 24 commits into from
Dec 10, 2023

Conversation

k4lizen
Copy link
Member

@k4lizen k4lizen commented Dec 5, 2023 •
edited by aleksasiriski
Loading

  • Changed error messages to be more standardized
  • Return errors in more places
  • Made colly always run async to have easier error handling (async doesn't return OnError errors)
  • Added comments after panics/fatals for clarity
  • Pulled Request error handling from engines out to sedefaults

k4lizen and others added 21 commits November 3, 2023 17:37
@k4lizen
refactor(error handling): starting cleanup
ef4b2d2
@k4lizen
fix(error handling): all non-engine-specific errors cleaned up
57b59ef
@k4lizen
refactor(error handling): pull out request error handling to sedefaul…
2619346 
…ts, make every call async
@k4lizen
fix(error handling): change message in Prepare
1ef14d1
@k4lizen
fix(error handling): changed error message in runEngines
a7289d8
@aleksasiriski
Merge branch 'main' into error-handling
a29d758
@k4lizen
chore: go mod tidy
15c3db4
@k4lizen
chore: merge main into error handling
4ee3857
@k4lizen
chore: go mod tidy
74b2fe8
@k4lizen
fix: fix timeout check, fix error check in search
4317b89
@k4lizen
chore: merge dontaskjustenjoy.go delete
9a1db93
@k4lizen
chore: add go.work.sum to .gitignore
6c8f790
@k4lizen
feat: add hrefExists check
2e12a81
@k4lizen
fix: pulled out PageFromContext to sedefaults
911bdaa
@k4lizen
fix: better response error logging
514a9a1
@k4lizen
feat: added lint to makefile
508920a 
golangci-lint run is a hard to remember command
@k4lizen
feat: added readme (#160)
63a56ac
@k4lizen
Merge branch 'main' into error-handling
bdde9ac
@k4lizen
chore: replaced returns with fatal/panic comments
3a16066
@k4lizen
chore: make update
99f8fd0
@k4lizen
chore: merge main
d6fe8c1
aleksasiriski
aleksasiriski requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge PR, will need to do one more inspection before merging.

src/cli/climode.go Show resolved Hide resolved
src/cache/redis/redis.go Show resolved Hide resolved
src/cache/redis/redis.go Show resolved Hide resolved
src/cli/climode.go Show resolved Hide resolved
src/router/search.go Outdated Show resolved Hide resolved
src/sedefaults/sedefaults.go Show resolved Hide resolved
src/sedefaults/sedefaults.go Outdated Show resolved Hide resolved
aleksasiriski
aleksasiriski approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, logic of when to fatal for db SET and GET can be done in a future PR.

@k4lizen k4lizen merged commit 531d784 into main Dec 10, 2023
3 of 4 checks passed
@k4lizen k4lizen deleted the error-handling branch December 10, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksasiriski aleksasiriski aleksasiriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k4lizen @aleksasiriski