Update/sling12 #681
Closed
Update/sling12 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h common-lang dependency. Also frontend-maven-plugin (node) was failing, but not sure what it does for server/ui.apps. Commenting out for now, also the module to build, install and deploy to Sling
Fix NPE due to incorrect the init method local variable 'resource' overriding instance property
…mple vue site can have new page without errors. Added TODO comments about nav and footer for these sites
…nderserver/components. Adjusted PageRenderServerConstants.java and /content/pagerenderserver/ paths accordingly
…source adaption (AdaptTo) for per:Page and per:Asset types; and their ability to get the correct per:Site resource as implemented in PerBaseImpl.java
…n page.html. Refactored Helper.java to allow siteCSS to exist under per:Site/jcr:content
…e pagerenderer/server module, it may be useful to continue support the npm build processes. this commit updates a few deps to keep updated with the other modules. may be necessary to mvn clean -PcleanNodeModules or reinstall via npm i.
…urces) returning a list of resources coming either from the template or the page content.
…nd iterating merged resources as htl
…elpers alike. Refactored PageHelper Use class to extend BaseHelper
…lper, updated PageHelper to use getters instead of direct access
…ite/jcr:content ValueMap
…the slingScriptHelper is null, then it will try to get the modelFactory from the bindings, which is added by the Adaption Jtest adds it. Use classes have bindings such as resource. Getting the resource from the request was problematic for testing, it is easier to test if PageMaerg.java uses the resource reference from the bindings, and not the reference attached to the request
…d to use resource from the bindings and not a reference through the request
…st whether getMergedResources properly merges template content with page content for HTL rendering
…plate content from a parent template
…SSR scenario 2: sub-template inheritance
…ces from parent templates
…iners in template with page content containers
…Container for SSR test 3
…red when creating new templates for pagerendervue tenant
…JS to /content/pagerenderserver/.content.xml. in anticipation of issue headwirecom#636. cleaned up base component
…state action such that refreshEditor is called and rendering is refreshed showing added components
…ows getting parent content from tenant root per:Site/jcr:content
…ly created pages. Tests that new pages they have containers for authoring and resources inherited from the template
…ntainer that merges children and properties for template and page resources
…e depending on author mode
… that they exist when setting their ACL's. Added Create folder directives for folders that might not exist yet in RepositoryInitializer-peregrine.config
|
FYI. I see the same error when executed against develop-sling12 e.g. Err:6 http://archive.ubuntu.com/ubuntu eoan Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issues