Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composum broken in develop-sling12 #569

Open
reggie7 opened this issue Sep 23, 2020 · 12 comments
Open

Composum broken in develop-sling12 #569

reggie7 opened this issue Sep 23, 2020 · 12 comments
Labels
1.0.0 Release Any fixes or enhancements required for the 1.0.0 release bug sling12

Comments

@reggie7
Copy link
Contributor

reggie7 commented Sep 23, 2020

Something is wrong with Composum in develop-sling12:

Composum

The cause is a js exception, not the above mentioned access issues:

js

The instance was started just like in 568.

@reggie7 reggie7 added bug HIGH! high priority sling12 labels Sep 23, 2020
@reusr1
Copy link
Contributor

reusr1 commented Sep 23, 2020

@reggie7 have you tried clearing caches? I currently do not see this issue but I also remember somebody else having an issue with composum and sling9 that was caused by a javascript error like this.

@reggie7
Copy link
Contributor Author

reggie7 commented Sep 23, 2020

Sadly I have cleared cache, tried incognito too...

@cmrockwell
Copy link
Collaborator

Some questions that maybe will help figure out what's happening.

  1. What does java -version report for Java version?
  2. Can you report details about the bundles http://localhost:8080/system/console/bundles
  • How many active? How many installed? Any other statuses?
  1. Do you see response codes 503 for any URL's? For example, does http://localhost:8080/system/sling/form/login work?

I have other hunches, but lets start here

@reusr1
Copy link
Contributor

reusr1 commented Sep 23, 2020

@reggie7 and you try again? for me at least this is fixed by f473526

@reusr1 reusr1 closed this as completed Sep 23, 2020
@reusr1 reusr1 reopened this Sep 23, 2020
@reggie7
Copy link
Contributor Author

reggie7 commented Sep 23, 2020

@cmrockwell

W:\>java -version
java version "11.0.7" 2020-04-14 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.7+8-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, mixed mode)

All bundles up and running. No 503, login page is working.

@cmrockwell
Copy link
Collaborator

cmrockwell commented Oct 16, 2020

My understanding was that it was resolved by ensuring settings for the admin allowlist were properly effective.
As mentioned in this Composum issue 105, their bundles require loginAdministrative, and that needs to be configured.

If someone experiences this type of issue, they can confirm first whether /system/console/configMgr has the admin settings shown below
Screen Shot 2020-10-16 at 11 06 47 AM

Specifically they can confirm there is an entry for composum
Screen Shot 2020-10-16 at 11 06 36 AM

This configuration should be applied for Composum, based on this feature definition
https://github.com/headwirecom/peregrine-cms/blob/develop-sling12/sling/peregrine-builder-sling-12/src/main/features/app/composum.json

I've heard reports that possibly restarting the instance might be needed, ymmv. However if not, then possibly review how Peregrine is launched in Sling12
https://github.com/headwirecom/peregrine-cms/blob/develop-sling12/sling/peregrine-builder-sling-12/README.md

Hopefully that helps

@reusr1
Copy link
Contributor

reusr1 commented Feb 24, 2021

closing this issue as this is solved by using the launcher/far from https://github.com/peregrine-cms/peregrine-builder - we had a bad repoinit script and an older version of composum configured

@reusr1 reusr1 closed this as completed Feb 24, 2021
@reggie7
Copy link
Contributor Author

reggie7 commented Feb 24, 2021

@reusr1 I don't think the issue is fixed. Just checked it on Windows machine on peregrine-builder/develop + peregrine-cms/develop-sling12 and the result is the same.

@reggie7
Copy link
Contributor Author

reggie7 commented Feb 24, 2021

@KWoloszczuk has the same problem. An I've just confirmed that with peregrine-builder/develop alone (prior to installing Peregrine).

@reggie7 reggie7 reopened this Feb 24, 2021
@ehdatheadwire
Copy link
Collaborator

@reggie7 and @reusr1 please confirm if this is still an issue and, if so, if it is required for 1.0.0 release. Marking ticket as close please / move :) .

@ehdatheadwire ehdatheadwire added Close Please! Tickets that have been reviewed and/or worked on but not closed Move scrubbed Ticket has been reviewed and assessed and removed HIGH! high priority labels Mar 12, 2021
@reusr1
Copy link
Contributor

reusr1 commented Mar 13, 2021

@ehdatheadwire it is still an issue but it seems to be limited to windows installations and seems to be an issue in https://github.com/apache/sling-org-apache-sling-starter (outside of the peregrine project). I have been trying to find the root cause of the issue in that project but have not been successful yet. getting closer :-)

@reusr1 reusr1 removed the Close Please! Tickets that have been reviewed and/or worked on but not closed label Mar 13, 2021
@ehdatheadwire ehdatheadwire added 1.0.0 Release Any fixes or enhancements required for the 1.0.0 release and removed Move scrubbed Ticket has been reviewed and assessed labels Mar 16, 2021
@reusr1
Copy link
Contributor

reusr1 commented Mar 26, 2021

this issue is now limited to windows 10 and some newer jvm's - the problem is that some content from the initial bundle content are created as files instead of a node structure - the problem is tracked as well in ist-dresden/composum-nodes#220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 Release Any fixes or enhancements required for the 1.0.0 release bug sling12
Projects
None yet
Development

No branches or pull requests

4 participants