Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: PluginSettingsDetail: ToDo completed #2840

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link
Contributor

Description

App/PluginSettingsDetail.tsx file was having a pending ToDo for error handling resolved that do by adding a catch block and setting up a notification system in it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 3, 2025
@illume
Copy link
Collaborator

illume commented Feb 5, 2025

Hrmm. The "Build Container and test..." job is failing. I reran it twice, and it keeps failing.

@DhairyaMajmudar
Copy link
Contributor Author

The workflow is failing as it is not able to run the command cd frontend && npm run build I tried running the same in my local setup and its running fine.

Can you pls. rerun the failing workflow after clearing the build cache

@DhairyaMajmudar DhairyaMajmudar force-pushed the frontend/PluginSettingDetails branch from d2a6304 to 60984f0 Compare February 5, 2025 17:16
@DhairyaMajmudar DhairyaMajmudar force-pushed the frontend/PluginSettingDetails branch from 60984f0 to 9a43fc7 Compare February 5, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants