frontend: add Chooser componnent stories #2824
Open
+1,188
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
sniok
reviewed
Feb 3, 2025
frontend/src/components/cluster/__snapshots__/Chooser.LoadingClusters.stories.storyshot
Outdated
Show resolved
Hide resolved
sniok
requested changes
Feb 3, 2025
Faakhir30
force-pushed
the
feat/new-chooser-stories
branch
from
78d6cc3 to
9bc15bd
Compare
Faakhir30
force-pushed
the
feat/new-chooser-stories
branch
from
9bc15bd to
326d0d1
Compare
sniok
requested changes
Feb 4, 2025
frontend/src/lib/k8s/index.ts
Outdated
| const allClusters = _.cloneDeep(state.allClusters || {}); | ||
|
|
||
| if (clusters === null) { |
There was a problem hiding this comment.
this changes the behavior of this function and breaks logic for statelessClusters branch. could you revert the change to this file please
There was a problem hiding this comment.
Yup, i was expecting something might break due to this
@sniok I did this because this function useClustersConf would always returns object || {} and never null, therefore
loading state would never be achieved IMO, refering these 2 lines:
https://github.com/headlamp-k8s/headlamp/blob/main/frontend/src/components/cluster/Chooser.tsx#L417
Therefore, Removing loading state story for now
Faakhir30
force-pushed
the
feat/new-chooser-stories
branch
from
326d0d1 to
f2a8b4a
Compare
Signed-off-by: Faakhir30 <[email protected]>
Faakhir30
force-pushed
the
feat/new-chooser-stories
branch
from
f2a8b4a to
1756226
Compare
|
Force pushed again, since e2e tests timed out after 13 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #931
Added clusterChooser components stories.
Heres snapshots video of current state:
Screencast from 2025-02-01 04-10-54.webm