Remove statements that would result in uncompacted index fields #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, when new fields were added in the GND source data, they would result in non-compacted URI field names, since they are not in the context. This is checked by `checkCompactedProperties.sh` for the test index, and production indexing is blocked if there are uncompacted fields. With this change, we remove the statements that would result in such fields instead and log that as an error.
dr0i
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, when new fields were added in the GND source data, they would result in non-compacted URI field names, since they are not in the context. This is checked by
checkCompactedProperties.shfor the test index, and production indexing is blocked if there are uncompacted fields. With this change, we remove the statements that would result in such fields instead and log that as an error.