-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved support for Java 11+ #68
Conversation
Change bytecode handling to explicitly fail rather than assume a type in switch cases Use objenesis instead of direct sun reflection-factory for instance creation Remove junit platform exclusion, resolving some failures with IntelliJ integration
…ak config to resolve intelliJ integrations failures.
Any suggestions for the applet test failures? Is there some setup I'm missing? |
@Col-E Sorry for delay, didn't have watcher turned on here. Its on now. I actually pulled your PR more directly as I did not see this, I haven't pushed it up yet. Will do so shortly as looking at some javadoc issues showing up. I suspect either this PR will show no more changes or auto close as applied. Letting it at least try to build even if the applet issue. I'm leaning towards just deleting the applets as I believe no browsers support any more anyways. |
👍
A total of 0 people weep 😏 |
painfully sticking to jdk 8 to allow the release process for time being (I prefer to use 17). something wrong with javadocs which is not super surprising based on how poorly maven javadoc plugin works in general. usually get some idea of issues but none really. running mvn javadoc:javadoc gave me some clues in modules not under my release parent control but none of the fixes I tried helped. However, able to release. Doing so now... |
Mirror of the PR on the upstream repo - (Copying description below)
Encountered some compatibility issues with a project due to outdated bytecode handling.
Other changes under the hood:
pom.xml
, resolving some failures with IntelliJ integrationValidity
I tested up to Java 17 using the maven tool-chain plugin with all tests passing when running
mvn test
. Though, using IntelliJ's JUnit runner one specific case fails (though I think this is due to test environment pollution since it doesn't fail when ran isolated or from maven directly)