Exercise Development Mode: Title Editor #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrus-
requested changes
Nov 21, 2022
src/haz3lweb/Log.re
Outdated
| @@ -36,6 +36,9 @@ let is_action_logged: Update.t => bool = | |||
| | ResetSlide | |||
| | ToggleMode | |||
| | SwitchSlide(_) | |||
| | SwitchTextEditor | |||
There was a problem hiding this comment.
Should we unify this with SwitchEditor since the focus can only be in one place at a time?
| @@ -36,6 +36,9 @@ let is_action_logged: Update.t => bool = | |||
| | ResetSlide | |||
| | ToggleMode | |||
| | SwitchSlide(_) | |||
| | SwitchTextEditor | |||
| | UpdateTitle(_) | |||
There was a problem hiding this comment.
Let's group all Exercise related actions into an ExerciseAction.t type that is injected into Action.t at once, to avoid having too many cases?
cyrus-
added
the
needs-polish
cyrus-
added
needs-merge
|
closing in favor of #1316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Haz3l title edit.