Readd warnings failing build in dev but exclude some unused warnings #1405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled Warnings:
26: Unused variable
27: Unused Variable Strict
32: Unused value declaration
33: Unused open statement
34: Unused type declaration
35: Unused for-loop index
38: Unused extension
39: Unused rec flag
58: Missing cmx file This was already in use
Rationale:
I had previously disabled warnings in dev in #1378. The idea being that you shouldn't restrict the ability to build given warnings, just the ability to deploy. Unfortunately dune only announces warnings the first time a module is built so you could have long lived local issues for serious warnings, i.e. missing cases in pattern-matching.
Unused warnings are allowed because they show up regularly as part of writing code and are easy to fix after a build failure in CI by just removing the unused code.