Try making all of the ids type parameters #1371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7h3kk1d
commented
Aug 13, 2024
Comment on lines
+16
to
+22
| type segment('a) = list(piece('a)) | ||
| and piece('a) = | ||
| | Tile(tile('a)) | ||
| | Grout(Grout.t) | ||
| | Secondary(Secondary.t) | ||
| | Projector(projector) | ||
| and tile = { | ||
| | Projector(projector('a)) | ||
| and tile('a) = { |
There was a problem hiding this comment.
This is the main idea for tiles.
7h3kk1d
commented
Aug 13, 2024
| // invariants: | ||
| // - length(mold.in_) + 1 == length(label) | ||
| // - length(shards) <= length(label) | ||
| // - length(shards) == length(children) + 1 | ||
| // - sort(shards) == shards | ||
| id: Id.t, | ||
| extra: 'a, |
There was a problem hiding this comment.
Rename this to something more relevant and have the inhabitants use a {id: Id.t} type rather than directly embed Id.t
7h3kk1d
commented
Aug 13, 2024
src/haz3lcore/statics/TermBase.re
Outdated
| | Cast(t, Typ.t, Typ.t) // first Typ.t field is only meaningful in dynamic expressions | ||
| and t = IdTagged.t(term); | ||
| | Cast(t('id), Typ.t, Typ.t) // first Typ.t field is only meaningful in dynamic expressions | ||
| and t('id) = IdTagged.t(term('id), 'id); |
There was a problem hiding this comment.
This doesn't feel like the right encoding but I'd like to talk with someone else about it before I fall down any more rabbit holes
- Still need to fix every callsite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still just an idea. Not sure if it's a good one.