-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summer UI Refresh #1343
Summer UI Refresh #1343
Conversation
looks good, and the proposed sequence for the bottom bar seems logical if you can make it look good. we should figure out what longer error messages look like as well (see #1127) |
@cyrus- agreed in principle but finding it hard to think of what exactly the general case for multiline errors should look like without bringing some higher-level markdown-type considerations and a pretty printer into it |
@cyrus- how do you feel about getting rid of show context inspector on hover and make it click-only? i want to make it so that it doesn't render when it's not visible for perf reasons, and its slightly complex to have two different visibility modes (pin and hover), so I want to make sure there's actually a reason to so do so. From my perspective, pin works fine. (i've removed the zen mode collapse option from both top and bottom bar, will revisit in the fuure) |
…r when not visible. show ContextInspector on click only (pin), not on hover
… previously encoded using a unicode linebreak symbol, for obscure reasons regarding regexp compatibility. now standard \n linebreaks are used. In exercise serialization, \226\143\142 should be find-replaced with \n
seems fine to me |
…+ html source. clean up palette
@cyrus- agreed, although a principled fix given the current model is not immediately apparent to me. or i guess to be specific, what aspect are you refering to? the coincidence of the ellipses with the concave grout or something with the error holes? |
if it's the ellipses, i could move them back to directly adjacent to the let. this feels slightly sub-optimal to me from a consistency standpoint but would definitely look better in this specific situation |
yeah moving the ellipses would be fine |
@cyrus- how do you feel about the ellipsis in general? the reason for this regression is that i removed a somewhat awkward and brittle hack in the completion system, not realizing how it would effect this case. I mildly prefer the ellipsis to nothing, but i never really thought of it as a long-term solution. in retrospect though I prefer nothing over having this hack in the system, and doing it properly involves too major a rewrite. as such i'm inclined to simply remove it |
removing the ellipses seems fine too |
…ne in code editors
… movemement actions not triggering a deselect
… mode are no longer truncated
@cyrus- all of those bugs and a few others (see newly-tagged issues) are fixed. |
the triple click issue is still there for me? |
@cyrus- forgot to push, should be there when it builds |
closes #144, #891, #968, #994, #1009, #1078, #1107, #1167, #1190, #1314, #1361, #1363.
Update to the Hazel top-level UI and general UI/deco cleanup.
Breaking changes:
⏎
character because of reasons. They are now represented using\n
, unwinding several long-standing hacks. This change requires regenerating any extant serialized hazel zippers. This can be done automatically by find-replacing\226\143\142
with\n
.Interaction Refresh:
Style Refresh:
Fixes (See also tagged issues):
Cleanup:
Docs:
Notes on vibe:
In general what I feel we're maybe moving towards is interpreting both bars as part of a linear progression between general and specific. The nut menu governs global settings (although some entries are contextual), and along with the 'hazel' title represents the root of the application. To the right, the mode selector (docs/scratch/exercises) represents a selection between different top-level application modes, and the following selector represent top-level-mode-specific sub-modes. The intention is that the upcoming breadcrumb inspector should immediately follow this, representing the levels hierarchy between the root editor level and the indicated (caret) term. Aspirationally, the mode selectors will become part of this breadcrumb view, and the 'hazel' element will become a representation of the actual root level of conjoined hazel program subsuming extant modes. The bottom bar is a continuation of the top bar, now at the the semantically most-local level. It might be worth considering re-ordering the elements to represent a flow from more general to more specific, in terms of the context-sensitivity of the semantics. The sort is likely the most general, being purely syntactic, followed by the typing context, which is context-sensitive but is generically applicable across all sorts. Then the term class. Perhaps this should be followed by the projectors UI, as projectors are applicable based on (to a first approximation) syntax class, with error status following as most specific.