-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Labeled Tuples #1235
Draft
WondAli
wants to merge
92
commits into
dev
Choose a base branch
from
labeled-tuple-rewrite
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement Labeled Tuples #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…: optimize hacks for cleaner code, fix more bugs
@WondAli playing with this branch, looks like the labels aren't showing up in the types of the tuples (and so you get weird run-time errors when projecting out a label that doesn't exist). is there a specific issue with adding labels to product types? |
…nmatched labels in function parameters
WondAli
force-pushed
the
labeled-tuple-rewrite
branch
2 times, most recently
from
August 24, 2024 21:16
b8e1f37
to
3c24406
Compare
WondAli
force-pushed
the
labeled-tuple-rewrite
branch
from
August 24, 2024 21:22
3c24406
to
fe24986
Compare
…when the label is not present
TODO test nested dot operators |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Implement Labeled Tuple functionality into Hazel.
Note: I don't think I can change the source branch on the old pull request. This redesign of the implementation was started on a new branch, so the old pull request (and branch) is outdated.
TODO: Add more detail to the pull request; add more detail about syntax and semantics
What are Labeled Tuples?
An element in a tuple can be "labeled" or "named" with the
=
operator. For example,(x=1, y=2)
is a tuple expression in which its elements are labeledx
andy
respectively. These labels are relevant only within their nearest enclosing tuple.The
=
operator can be thought of as a binary operator that takes in a string and an expression, and returns the expression.(Uncertain) A labeled element is type-consistent with the type of the element it is labeling.
Labeled Tuple Features
When analyzed against a labeled tuple type, the labeled items can be placed anywhere in the tuple expression and tuple type (the unlabeled items must be in relative order to each other).
(x=1, True, y=6)
is properly typed against(Bool, y=Int, x=Int)
Let x=a, b = (y=2, x=4)
will bind4
toa
and2
tob
Dot Operators
The dot operator
.
can be applied to a tuple to extract a labeled element.For example,
(x=1, 2, 3).x
is equivalent to1
Currently undefined for anything except tuple expressions.
Implementation Strategy
Checkpoints:
Known Bugs: