Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] Langchain integration 4j Documentation #1358

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Nov 1, 2024

No description provided.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 82140af
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/675b25e2bd212b0008b676cb
😎 Deploy Preview https://deploy-preview-1358--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuce yuce changed the title Langchain integration 4j Documentation [DON'T MERGE] Langchain integration 4j Documentation Nov 14, 2024
@yuce yuce requested a review from Rob-Hazelcast as a code owner November 14, 2024 08:31
@oliverhowell oliverhowell self-assigned this Nov 21, 2024
@yuce yuce requested a review from a team as a code owner December 12, 2024 15:12
@Rob-Hazelcast Rob-Hazelcast marked this pull request as draft December 12, 2024 16:02
Copy link
Contributor

@Rob-Hazelcast Rob-Hazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I've pushed some minor copy edits.

Does any of the existing documentation need updating as a result of this new feature, or to reference it? Presumably this will be included in release notes and what's new? @oliverhowell


The `builder` method creates an instance of `HazelcastEmbeddingStore.Builder`.

`HazelcastEmbeddingStore` needs to communicate with a Hazelcast Enterprise cluster to send embeddings and retrieve search results. You can supply cluster configuration parameters using one of the following methods:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, is this effectively an Enterprise feature and should these new sections be tagged as such?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants