Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Moves default image registry to quay.io #132 #229

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: Moves default image registry to quay.io #132 #229

merged 1 commit into from
Nov 30, 2023

Conversation

phantomjinx
Copy link
Member

@phantomjinx phantomjinx commented Nov 29, 2023 •
edited
Loading

  • deployment.yml

    • Updates image property to point to quay.io

  • package.json

    • Updates companion commands to point to quay.io

  • Makefile

    • Makes VERSION parameter overrideable from ENV
    • Updates IMAGE_NAME to quay.io
    • Adds VERSION override that updates SNAPSHOT suffix with date timestamp
    • Removes clutter of bundle-making as only applicable to operator

@phantomjinx phantomjinx marked this pull request as draft November 29, 2023 18:12
@phantomjinx
fix: Moves default image registry to quay.io hawtio#132
b8384b3 
* deployment.yml
 * Updates image property to point to quay.io

* package.json
 * Updates companion commands to point to quay.io

* Makefile
 * Makes VERSION parameter overrideable from ENV
 * Updates IMAGE_NAME to quay.io
 * Adds VERSION override that updates SNAPSHOT suffix with date timestamp
 * Removes clutter of bundle-making as only applicable to operator
@phantomjinx phantomjinx marked this pull request as ready for review November 29, 2023 18:18
tadayosi
tadayosi approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@tadayosi tadayosi merged commit 4b68236 into hawtio:main Nov 30, 2023
3 checks passed
@phantomjinx phantomjinx mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

@mmelko mmelko Awaiting requested review from mmelko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phantomjinx @tadayosi