Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rp2040 - ISO API to make Audio work #2843

Closed
wants to merge 76 commits into from
Closed

Rp2040 - ISO API to make Audio work #2843

wants to merge 76 commits into from

Conversation

pschatzmann
Copy link
Contributor

@pschatzmann pschatzmann commented Oct 15, 2024 •
edited
Loading

Following the discussion that the RP2040 is missing the new ISO API, here is my take on it.
I added the 2 following methods

  • bool dcd_edpt_iso_alloc(uint8_t rhport, uint8_t ep_addr, uint16_t largest_packet_size)
  • bool dcd_edpt_iso_activate(uint8_t rhport, tusb_desc_endpoint_t const * p_endpoint_desc)

I was keeping the existing logic and I just needed to split up some functions to fit the new logic.

This is addressing this issue.
See #1802 (comment)

I am not sure why this pull request is generating so many changes:
I only changed the following files

  • tusb_mcu.h (to activate the ISO API)
  • dcd_rp2040.c (see above)
  • video_device.c (to correct a data cast error because ep_addr was defined as uint16_t instead of uint8_t)

YixingShen and others added 30 commits July 18, 2024 00:46
@YixingShen
fixed _find_desc_format
15766ad
@hathach
change vendor device to use edpt stream API
867f17a
@hathach
update edpt_stream to support non-buffered (no fifo) mode
c003081
@hathach
change edpt stream api to take hwid from API to reduce memory footprint
cc816dc
@hathach
update vendor device to use edpt stream which also support non-buffer…
bbeae09 
…eed (no fifo) mode
@hathach
minor clean up
7373a02
@hathach
remove vendor ep_addr, use stream api instead
3ab63fb
@hathach
reduce ep stream footprint by using is_mps512 since it only support b…
dd1822b 
…ulk so far
@hathach
fix warnings
7909a62
@hathach
ep stream init: wrap with OSAL_MUTEX_REQUIRED, only create fifo mutex…
9b4bb61 
… if needed
@hathach
Merge pull request #2450 from HiFiPhile/vendor_fifo
4b107a2 
Allow vendor class to be used without FIFO.
@hathach
[circleci] fix build with rx by get-deps before install toolchain
013b448
@hathach
Merge pull request #2794 from hathach/fix-circleci
91c8700 
[circleci] fix build with rx by get-deps before install toolchain
@hathach
add pico2 rp2350 (arm) board
c419b1e 
add pico2 to hil ci
@hathach
Merge pull request #2799 from hathach/add-pico2
3ff128b 
add pico2 rp2350 (arm) board
@hathach
prepare for 0.17.0 release
115b1bb
@hathach
Merge pull request #2801 from hathach/release-0.17.0
5217cee
@UweBonnes
Add STM32 B_5585I-IOT2A board
2c27f29
@hathach
Merge pull request #2803 from UweBonnes/b_u585i-iot
f4dd176 
Add STM32 B_5585I-IOT2A board
@shuffle2
make all python files executable and standardize interpreter
6165328
@hathach
Merge branch 'refs/heads/master' into fork/HiFiPhile/dwc2_dma
9bfb3e7
@hathach
skip pico2 dual test, it seems not stable
40b5517
@hathach
update dfifo allocation scheme to use top pointer, update document an…
86b4608 
…d explanation for EPInfo address and GDFIFO.

some function rename
update h743 linker to use SRAM1 since USB DMA cannot access DTCM ram
update xmc4500 to use uuid for testing
@hathach
add CFG_TUD_DWC2_DMA, make it compile time option
a124438
@hathach
more rename
6a15e78
@HiFiPhile
Add a note about data cache.
e483c6a
@hathach
Merge pull request #2576 from HiFiPhile/dwc2_dma
c8ab65f 
DWC2 DMA support
@hathach
Migrate hil vm (#2822)
e209acb 
* migrate hil to new x64 VM instead of rpi
* re-enable hil for s3
@hathach
update to dwc2 register struct
47233f8
@hathach
update/rename ghwcfg registers
bb2d1dd
hathach and others added 28 commits October 4, 2024 16:33
@hathach
enable dma hil test with hfp.json
7cdab1c
@hathach
revert hfp dma for now, due to ci build matrix
790a107
@hathach
fix circleci set-matrix
0abd647
@hathach
U0 does not have dwc2 controller
73f7ce7
@hathach
update new json change
31c123a
@hathach
Merge pull request #2827 from hathach/ci-dwc2-dma
4e0d534 
Ci dwc2 dma
@hathach
Merge pull request #2824 from Maerdl/master
6bfd024 
support stm32U0 device
@hathach
Merge pull request #2809 from shuffle2/master
a13dbd4 
make all python files executable and standardize interpreter
@hathach
Merge pull request #2720 from YixingShen/master
65242fd 
fixed video_device.c _find_desc_format
@hathach
enhance dwc2 markdown with field mapping
cb5e273
@hathach
add stm32f769disco to hil pool
b2a98ea
@hathach
improving dwc2, merging diep and doep if possible
599bb0c
@hathach
add f407disco to hil pool
07c14f3
@hathach
enhance dwc2
98e94a5
@hathach
remove stm32f769disco since it is not reliable
c343796
@hathach
clion files
ba3a5b4
@hathach
remove debug code
1406ad8
@hathach
Merge pull request #2833 from hathach/update-dwc2
ffdf81f 
more dwc2 enhance
@hathach
add new tusb_int_handler(rhport, in_isr) as common irq handler
57aac43 
update tusb_init() to take rhport and role, defined as macro with optional argument for backward compatible
@hathach
Merge pull request #2834 from hathach/add-tusb_int_handler-update-tin…
a4fb835 
…yusb_init

add new tusb_int_handler(rhport, in_isr) and update tusb_init(rhport, role)
@hathach
change tusb_init(), tusb_rhport_init() to use init struct for expanda…
92602b9 
…bility
@hathach
change dcd_init() to take rhport struct
d997f00
@hathach
fix fuzzing build
f3b7d75
@hathach
hcd_init() take init struct
1587d48
@hathach
change the tusb_rhport_init_t struct, exclude the rhport to make API …
1f18be9 
…more consistent
@hathach
change dcd_init() return from void to bool
e83e083
@hathach
Merge pull request #2836 from hathach/more-tusb_init()
933ac29 
change tusb_init() to use init struct
@pschatzmann
RP2040 ISO API
43e4f14
@pschatzmann
Copy link
Contributor Author

I will resubmit this based on the dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pschatzmann @YixingShen @hathach @UweBonnes @shuffle2 @HiFiPhile @Maerdl